search

neomerx / json-api

Framework agnostic JSON API (jsonapi.org) implementation
Apache License 2.0
743 stars 66 forks source link

Fix iterating over relationship data generator when generator is empty #252 #253

Closed lindyhopchris closed 8 months ago

lindyhopchris commented 3 years ago

As described in the issue, if relationship data was an empty generator, an error would be triggered as the generator was iterated over twice when including related resources.

This is because the cache in RelationshipDataIsCollection was not being set to an empty array.

This PR adds two tests: one for a non-empty generator, and another for an empty generator. The empty generator test was failing before the single line fix was put into RelationshipDataIsCollection.

Closes #252

lindyhopchris commented 8 months ago

Closing this - it's still required, but ultimately it looks like this package is no longer maintained. Someone can reopen if that situation changes.