neomjs / neo

The application worker driven frontend framework
https://neomjs.com
MIT License
2.89k stars 162 forks source link

neo theme files: auto-generate css vars #3604

Closed tobiu closed 1 month ago

tobiu commented 1 year ago

we do have boilerplate code inside our theme files:

$neoMap: map-merge($neoMap, (
    'boxlabel-background-color': #323232,
    'boxlabel-border'          : 0,
    'boxlabel-color'           : #ddd
));

@if $useCssVars == true {
    :root .neo-theme-dark { // .neo-box-label
        --boxlabel-background-color: #{neo(boxlabel-background-color)};
        --boxlabel-border          : #{neo(boxlabel-border)};
        --boxlabel-color           : #{neo(boxlabel-color)};
    }
}

we should check if the build and watch-themes scripts could auto-generate the part inside the if statement.

tobiu commented 1 year ago

@maxrahder

tobiu commented 1 year ago

added the good first issue label, since this ticket does not require any knowledge about the framework.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] commented 1 month ago

This issue was closed because it has been inactive for 14 days since being marked as stale.