neomjs / neo

The application worker driven frontend framework
https://neomjs.com
MIT License
2.89k stars 161 forks source link

button.Base: polish the ripple effect styling #5868

Closed tobiu closed 2 months ago

tobiu commented 2 months ago

i noticed 2 glitches inside the new theme:

  1. the ripple wrapper needs to use the same border radius as the button
  2. we need to add left: 0 and top: 0 to compensate for button paddings => to ensure the overall position is correct

@mxmrtns

tobiu commented 2 months ago

https://github.com/user-attachments/assets/38bc9cfc-7959-4275-9493-e5318532e403