search

neon-bindings / neon

Rust bindings for writing safe and fast native Node.js modules.
https://www.neon-bindings.com/
Apache License 2.0
7.98k stars 282 forks source link

refactor(cargo-cp-artifact): use `copyArtifact` from `@neon-rs/artifact` #1046

Open dherman opened 3 months ago

dherman commented 3 months ago

Closes #1045.

kjvalencik commented 3 months ago

cargo-cp-artifact currently has zero dependencies. I'm not sure if adding one for ~20 LoC is worth it.

dherman commented 3 months ago

cargo-cp-artifact currently has zero dependencies. I'm not sure if adding one for ~20 LoC is worth it.

It's an internal dependency, though: we maintain all the code. It's just that we use it in two different CLI tools, so it avoids us having to maintain it in two places.

kjvalencik commented 3 months ago

Given that we are likely to stop maintaining cargo-cp-artifact, my preference is not to couple the two and potentially make the neon CLI more difficult to maintain.