neon-bindings / neon

Rust bindings for writing safe and fast native Node.js modules.
https://www.neon-bindings.com/
Apache License 2.0
8k stars 283 forks source link

`JsArray::new()` takes a usize #988

Closed dherman closed 1 year ago

dherman commented 1 year ago

From the list of remaining breaking changes, this PR implements the one and only remaining case where the Neon API uses a u32 but should use a usize: JsArray::new().

I did an audit of all other occurrences of u32 in the codebase and all the remaining instances are fine: