neon-bindings / neon

Rust bindings for writing safe and fast native Node.js modules.
https://www.neon-bindings.com/
Apache License 2.0
8k stars 283 forks source link

remove `JsFunction` type parameter #989

Closed dherman closed 1 year ago

dherman commented 1 year ago

From the list of remaining breaking changes, this PR removes the JsFunction type parameter. This is safe for the following reasons:

dherman commented 1 year ago

I added a unit test that uses the global object, so it'll have a small merge conflict with #987.

kjvalencik commented 1 year ago

I love the tests checking that constructions are still objects! ❤️