neon-bindings / rfcs

RFCs for changes to Neon
Apache License 2.0
14 stars 9 forks source link

RFC: infallible `JsString::new()` constructor #21

Closed dherman closed 6 years ago

dherman commented 6 years ago

This draft RFC proposes a backwards-incompatible change to the JsString::new() API to make it infallible, along with a JsString::try_new() companion API for explicitly handling the (rare) error case of overflowing the maximum string length limit.

Rendered

dherman commented 6 years ago

📢 This RFC is going into final comment period! We will plan to merge it within a week if there aren't significant new issues that arise in the next week. 📢