RFC: add pyo3-like attribute macros to define nodejs classes and methods

Mossaka commented 3 years ago

Signed-off-by: Joe Zhou jiazho@microsoft.com

Mossaka commented 3 years ago

Updated RFC with the comments.

esatterwhite commented 2 years ago

Would love to see this added back. Very much missing it from the recent versions

louneskmt commented 2 years ago

Any update on this RFC?

kjvalencik commented 2 years ago

@louneskmt No update. This RFC itself is blocked by being able to create classes (i.e., a type safe wrappers around napi_define_class and napi_wrap).

While this feature is highly desirable, it's not considered a blocker for Neon 1.0 because the functionality can be accomplished with some JavaScript glue code. Blockers for 1.0 have taken priority.

Contributions would be welcome. I have spent a bit of time thinking about what Neon's napi_define_class might look like. Most likely:

A trait providing a constructor, name, and properties
An instance data cache that can lookup constructors based on the implementing type
Some code for wrap/unwrap that operates similar to JsBox

neon-bindings / rfcs

RFC: add pyo3-like attribute macros to define nodejs classes and methods #43