search

neon-jungle / wagtail-birdsong

Create, send, preview, edit and test email campaigns from within Wagtail
BSD 3-Clause "New" or "Revised" License
105 stars 26 forks source link

Updates for wagtail 2.15 and django 4 compatibility #15

Closed danhayden closed 2 years ago

danhayden commented 2 years ago

Changes in wagtail 2.15 modeladmin templates caused birdsong templates to break visually and prevented the preview iframe from working due to the form selector in preview_campaign.js matching the wrong form on the page.

Fixes #14

danhayden commented 2 years ago

Have also added the migration files which I had previously missed. Should also fix https://github.com/neon-jungle/wagtail-birdsong/issues/18

seb-b commented 2 years ago

I've noticed a visual problem when checking out the branch image

Ideally these shouldn't be stacked, they should be side-by-side with a bit of spacing between

danhayden commented 2 years ago

I've pushed a fix and tested on wagtail 2.15.5 and wagtail 3.0

on wagtail 2.15.5:

edit-view-wagtail-2 15 5

on wagtail 3.0:

edit-view-wagtail-3 0

danhayden commented 2 years ago

This PR should now be complete

Fixes https://github.com/neon-jungle/wagtail-birdsong/issues/14 Fixes https://github.com/neon-jungle/wagtail-birdsong/issues/17 Fixes https://github.com/neon-jungle/wagtail-birdsong/issues/18 Closes https://github.com/neon-jungle/wagtail-birdsong/issues/19

seb-b commented 2 years ago

Awesome work @danhayden, thanks heaps. Noticed one small django 4 problem but I'll fix it up in an upcoming branch. I'll release this in version 1.0.0 sometime today