Closed jkevingutierrez closed 4 years ago
Ah good pickup, I've left one comment.
So it looks like wagtailadmin/shared/header.html
was changed in 2.10 to take a different parameter. (add_link
-> action_url
)
So this is the correct approach for 2.10+. We can either make a convoluted approach that loads a different template based on the wagtail version, or I'll make then next release require wt>2.10
@seb-b It could also include both parameters, like:
{% include "wagtailadmin/shared/header.html" with
title=video_str
add_link="wagtailvideos:add_multiple"
action_url="wagtailvideos:add_multiple"
icon="media"
add_text=add_video_str
action_text=add_video_str
search_url="wagtailvideos:index" %}
What do you think?
@jkevingutierrez Yep, thats a good workaround, happy for both parameters to be used :)
add_link
should just be the string "wagtailvideos:add_multiple"
action_url
should be the reversed url, like you originally had
@seb-b done. Adding both parameters also fixed the tests https://travis-ci.org/github/neon-jungle/wagtailvideos/builds/723947902
Released in 2.8.2 :tada:
Fix #45