neon-jungle / wagtailnews

News/blog plugin for Wagtail CMS
http://pypi.python.org/pypi/wagtailnews/
BSD 2-Clause "Simplified" License
74 stars 21 forks source link

NewsChooser does not work after upgrading to wagtail 2.12.4 #29

Closed bmihelac closed 1 year ago

bmihelac commented 3 years ago

After upgrading wagtail to 2.12.4 chooser modal does not work, relevant error from stacktrace is

  File "/.venv/lib/python3.6/site-packages/wagtailnews/views/chooser.py", line 159, in choose_modal
    paginator, paginated_items = paginate(request, newsitem_list, per_page=10)
TypeError: paginate() got an unexpected keyword argument 'per_page'

paginate function indeed does not have per_page.

Quick fix for this error, yields another error:

  File "site-packages/wagtail/admin/modal_workflow.py", line 11, in render_modal_workflow
    raise TypeError("Passing a js_template argument to render_modal_workflow is no longer supported")
TypeError: Passing a js_template argument to render_modal_workflow is no longer supported
seb-b commented 1 year ago

2.12 is out of support range now