search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
167 stars 21 forks source link

neonvm: Replace deprecated generate-groups.sh with kube_codegen.sh #1053

Closed sharnoff closed 3 months ago

sharnoff commented 3 months ago

The new script is a completely different format :( See e.g. kubernetes/kubernetes#117262 for examples.

Changes required here:

  1. Passing through the git directory, even when using worktrees, because kube_codegen.sh directly uses git for things (git grep, git ls-files)
  2. Patching kube_codegen.sh because it expects that our types files are exactly types.go, but we have virtualmachine_types.go and virtualmachinemigration_types.go.

There are further breaking changes in later kubernetes versions, but we don't need to deal with those quite yet.

Extracted from #1048.

Notes for review: Please check it runs locally. Do not approve this PR unless you have checked that make generate works for you.