neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
163 stars 21 forks source link

neonvm: Cleanup kustomize #824

Closed sharnoff closed 8 months ago

sharnoff commented 8 months ago

This PR combines #779 and #812, leaving out removing the controller metrics proxy - that's left for a follow-up PR (this one is focused on not changing the yaml).

Brief summary of changes:

  1. Rename neonvm/config/common/controller/{manager => deployment}.yaml
  2. Remove neonvm/config/default/
    • This is not currently used. AFAIK it was never seriously used, but I'm not 100% sure.
  3. Collapse neonvm/config/common/* and neonvm/config/default-vxlan/* into neonvm/config/
    • Basically, after removing neonvm/config/default, there's only one target to produce, and so there's no need to have a separation between the "common" components vs the ones specific to default-vxlan
  4. Merge kustomize patches into source yamls
    • Previously these were needed because of the common/default[-vxlan] separation, or were generated as part of skaffold — they make things much more complex though, and merging them back into the objects they change should make things simpler.

Supersedes #779. Supersedes #812.


Notes for review: Probably easiest to go commit-by-commit?


Plan for merging: will rename commits to include the PR number, and then merge via rebasing onto main.