search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
163 stars 21 forks source link

neonvm: Remove support for pre-v0.7.0 neonvm-runner versions #836

Closed sharnoff closed 7 months ago

sharnoff commented 8 months ago

In short: Handling for supporting pre-"fractional CPU" neonvm-runner versions introduces complexity via subtle logic that's hard to check in practice, because we haven't run any versions this old in a long time.

Resolves #710.

Omrigan commented 8 months ago

I would replace "old" in commit subj with the concrete version number which was made incompatible

Omrigan commented 7 months ago

Remove support for pre-v1 neonvm-runner versions

I'd write pre-v0.7.0.

We definitely don't have computes alive for 11 months, do we?

sharnoff commented 7 months ago

I'd write pre-v0.7.0

Ah yeah, good point

We definitely don't have computes alive for 11 months, do we?

nope — see here: https://github.com/neondatabase/autoscaling/issues/710#issuecomment-1967478953