Closed idrawone closed 5 months ago
Thanks for the PR! IIRC, these are intentional — in order to render the manifests, we modify the files to temporarily set the images to the desired values (which are frequently not the default), then set them back to the "default" ones once rendering is done.
LMK if there's something I'm missing
I agree with what @sharnoff said.
I'll close this in a meantime, feel free to open a new one if the need arises.
All the image names have corresponding variables defined at the beginning of the Makefile, but despite this, some hardcoded image names are still being used. This simple patch replaces those hardcoded image names with the corresponding variables for better maintenance.