search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
150 stars 20 forks source link

neonvm-runner: Log parallel errors before returning #893

Closed sharnoff closed 5 months ago

sharnoff commented 5 months ago

Explanation taken from the added comment:

(*errgroup.Group).Wait() returns at most 1 error, which means imprecise usage can hide errors. So, we log the errors before they would be returned, to make sure they're always visible.

In particular, this is required to make sure that #887 is sound.