search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
150 stars 20 forks source link

agent: push metrics to S3 #898

Closed Omrigan closed 3 months ago

Omrigan commented 4 months ago

Add s3 billing destination.

Part of a neondatabase/cloud#9825

Omrigan commented 4 months ago

Initial review, mostly nits. Haven't reviewed the python. There's also some subtlety around client errors that I need to dig more deeply into.

Can you expand?

I think it's also missing s3 client config validation pkg/agent/config.go.

Fixed in 3bfdec7d71269039bed4070c193d8023468ded4a

In general, looks quite good! Feels sparse on comments — I'm left without any hints for building my mental context.

LMK where exactly, I only came up with d7bc1b1