I think these were leftovers from when we were still using klog, which required us to embed complex data via string formatting. But since switching to zap this is now irrelevant.
This commit leaves some of the Format() implementations as they are, for smaller types that we're actually likely to include in strings (like api.Bytes or vmv1.MilliCPU).
I think these were leftovers from when we were still using klog, which required us to embed complex data via string formatting. But since switching to zap this is now irrelevant.
This commit leaves some of the
Format()implementations as they are, for smaller types that we're actually likely to include in strings (likeapi.Bytesorvmv1.MilliCPU).This also came up previously: https://github.com/neondatabase/autoscaling/pull/781#discussion_r1528181115
Pulled this commit out of #895 because I wanted it while working on #517.