search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
153 stars 21 forks source link

neonvm/api: Fix SwapInfo-related backwards compatibility issues #911

Closed sharnoff closed 5 months ago

sharnoff commented 5 months ago

In short, the PR switching swap to SwapInfo (#887) added checks for backwards compatibility, but an older client operating with newer NeonVM could still break because after reconciling the controller would replace the resource.Quantity for swap with a struct, and then because the type is different from expected, the older client would fail to fetch the VM if it tried to do that in the future.

In addition to that, the CRD change prevented creating VMs with the old, string-based swap field.

ref https://neondb.slack.com/archives/C033A2WE6BZ/p1713290569648829

sharnoff commented 5 months ago

Closing, because this approach actually wasn't enough.

See #912 for more.