search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
144 stars 18 forks source link

neonvm-controller: introduce unit tests #935

Closed Omrigan closed 4 weeks ago

Omrigan commented 2 months ago

First PR, introducing unit tests. The old functional tests are moved to a functest directory.

Part of #763

sharnoff commented 2 months ago

Not a full review, but brief thoughts: At first glance, seems like there's a couple other changes that might be good to separate out into other PRs (to make them separate, and merged faster) — in particular, thinking of golangci-lint bump + renaming the files in neonvm/controllers.

Also, not sure if it's still the case, but IIRC there's some requirements around exact matching between golangci-lint versions & the go toolchain version. IIRC #885 was blocking upgrading the Go version, so maybe we can do that now?