By default, zap enables "log sampling" when not in development mode. Unsurprisingly, we're finding that neonvm-controller logs are being dropped in production as a result of this.
I couldn't find a clean way to disable sampling without entirely constructing the zap.Logger from scratch, so that's what I did.
Notable changes:
neonvm-controller's --zap-* flags have been removed
neonvm-controller now hard-codes the logger config we were using before -- info log level, stack traces on panic, and ISO8601 time
By default, zap enables "log sampling" when not in development mode. Unsurprisingly, we're finding that neonvm-controller logs are being dropped in production as a result of this.
I couldn't find a clean way to disable sampling without entirely constructing the
zap.Logger
from scratch, so that's what I did.Notable changes:
--zap-*
flags have been removedMore context here: https://neondb.slack.com/archives/C03TN5G758R/p1716775758112349?thread_ts=1716765298.436929 See also: #475