k3d: Pass through auth for docker.io in CI

neondatabase / autoscaling

Postgres vertical autoscaling in k8s

Apache License 2.0

142 stars 16 forks source link

k3d: Pass through auth for docker.io in CI #978

Closed sharnoff closed 1 week ago

sharnoff commented 2 weeks ago

Fixes #975.

~~TODO: figure out why it isn't working~~

sharnoff commented 2 weeks ago

Turns out it's not quite fixed, unfortunately: https://github.com/neondatabase/autoscaling/actions/runs/9576387644/job/26402955386#step:15:2360

(unless this was actually hitting rate limits with our dockerhub account)

sharnoff commented 2 weeks ago

Turns out it just needed to be registry-1.docker.io instead of docker.io, see more here: https://devops.stackexchange.com/a/16154

Edit: I was repeatedly running e2e-tests from this PR in order to get another job to place away from the runner that was hitting the rate limit, which seemed to work -- i.e. with this PR, e2e-tests no longer hits the rate limit :)