search

neondatabase / autoscaling

Postgres vertical autoscaling in k8s
Apache License 2.0
142 stars 16 forks source link

Set hostname in the VM to "vm-<compute name>" #998

Open hlinnaka opened 1 week ago

hlinnaka commented 1 week ago

Mainly, to have it show up in the shell prompt, when you ssh into a compute VM. Which in turn can help to avoid mistakes like mixing up different computes.

sharnoff commented 6 days ago

+1 that this should change, I think I'd rather make this change on the VM spec, although not 100% sure. WDYT?

cc @Omrigan

hlinnaka commented 5 days ago

+1 that this should change, I think I'd rather make this change on the VM spec, although not 100% sure. WDYT?

No opinion, this just seemed like the simplest way to accomplish it.

hlinnaka commented 5 days ago

I just noticed that this PR contains a bunch of unrelated changes. Sorry about that! I'll clean it up..

hlinnaka commented 5 days ago

I just noticed that this PR contains a bunch of unrelated changes. Sorry about that! I'll clean it up..

Done.

Omrigan commented 1 day ago

+1 that this should change, I think I'd rather make this change on the VM spec, although not 100% sure. WDYT?

cc @Omrigan

We currently don't have a way to configure hostname in the spec, so why introduce? I don't see a use-case for having a custom hostname, so I like the approach of this PR.