feat: output password - Githubissues

neondatabase / create-branch-action

GitHub Action to create a new Neon branch

30 stars 7 forks source link

feat: output password #38

Closed aldenquimby closed 12 months ago

aldenquimby commented 1 year ago

Background

My team uses Flyway for database migrations
Flyway uses the JDBC postgres driver, which doesn't work with the output db_url
- instead of postgres://USER:PASS@HOST/DB, it's jdbc:postgresql://HOST/DB?user=USER&password=PASS

Proposal

This PR adds password as an output, so that we can run Flyway migrations (or any other non-psql based migration system) after create-branch-action

Alterantives

I could instead store a separate secrets.NEON_PASSWORD, but I'd prefer to only need secrets.NEON_API_KEY given that neonctl returns everything I need
I could use neonctl directly instead of this action

aldenquimby commented 1 year ago

@duskpoet thoughts on this? My team is using a fork for now

aldenquimby commented 1 year ago

@duskpoet great, thank you! I don't have write access to the repo, so will leave it to you to merge. Appreciate the quick reviews