search

neondatabase / create-branch-action

GitHub Action to create a new Neon branch
30 stars 7 forks source link

db_url doesn't contain sslmode=require #44

Closed noqcks closed 8 months ago

noqcks commented 8 months ago

Steps to reproduce

Use the create-branch-action

Expected result

db_url output to contain the full connection string including sslmode=require

Actual result

db_url doesn't contain sslmode=require

duskpoet commented 8 months ago

It's a no brainer to add that, but that would likely break users who add it manually... I guess I will release a new major version

hussamkhatib commented 8 months ago

That will not allow anyone to use other sslmodes. https://neon.tech/docs/connect/connect-securely

duskpoet commented 8 months ago

I guess the default of sslmode=require with a possibility to change works for everyone?

duskpoet commented 8 months ago

Ok, in the new v5 version sslmode=require is appended by default, with an option to override