search

neondatabase / helm-charts

neondatabase helm charts
Apache License 2.0
38 stars 3 forks source link

storage controller: use Recreate restart policy #75

Closed jcsp closed 6 months ago

jcsp commented 6 months ago

It isn't strictly unsafe to run two at the same time, but not very elegant. In future we may make this slicker to support larger scale (where restarts will be a bit slower)

via https://github.com/neondatabase/neon/issues/6342

jcsp commented 6 months ago

Bit confused about this linter error: the PR does bump the version from 1.0.6 to 1.0.7

Linting chart "neon-storage-controller => (version: \"1.0.7\", path: \"charts/neon-storage-controller\")"
Checking chart "neon-storage-controller => (version: \"1.0.7\", path: \"charts/neon-storage-controller\")" for a version bump...
Error: failed linting charts: failed processing charts
Old chart version: 1.0.7
New chart version: 1.0.7
fcdm commented 6 months ago

Bit confused about this linter error: the PR does bump the version from 1.0.6 to 1.0.7

Linting chart "neon-storage-controller => (version: \"1.0.7\", path: \"charts/neon-storage-controller\")"
Checking chart "neon-storage-controller => (version: \"1.0.7\", path: \"charts/neon-storage-controller\")" for a version bump...
Error: failed linting charts: failed processing charts
Old chart version: 1.0.7
New chart version: 1.0.7

You might need to rebase, current version seems to be 1.0.7:

https://github.com/neondatabase/helm-charts/blob/main/charts/neon-storage-controller/Chart.yaml#L5

jcsp commented 6 months ago

You might need to rebase, current version seems to be 1.0.7:

Yep, that's what was going on