neondatabase / helm-charts

neondatabase helm charts
Apache License 2.0
39 stars 3 forks source link

Revert "Don't quote splitThreshold" #84

Closed jcsp closed 6 months ago

jcsp commented 6 months ago

Crazy times with YAML & Go...

In https://github.com/neondatabase/helm-charts/pull/83 I got rid of the | quote because that was a possible cause of an integer getting wrongly formatted.

However, even after https://github.com/neondatabase/aws/pull/1358 changes the input type of splitThreshold to a string, the substitution into kubernetes YAML implicitly turns it back into an integer, and kubernetes requires that all the elements in the commands array be strings (not just things that can be string-ized).

TLDR: to make the splitThreshold work, we just need to add the | quote back. This was tested in https://github.com/neondatabase/aws/pull/1361 by deploying with the earlier version of the helm chart.