neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.
https://neon.tech
Apache License 2.0
13.2k stars 367 forks source link

storcon: improve drain and fill shard placement #8119

Closed VladLazar closed 1 week ago

VladLazar commented 1 week ago

Problem

While adapting the storage controller scale test to do graceful rolling restarts via drain and fill, I noticed that secondaries are also being rescheduled, which, in turn, caused the storage controller to optimise attachments.

Summary of changes

Checklist before requesting a review

Checklist before merging

github-actions[bot] commented 1 week ago

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)


Code coverage* (full report)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
de1f108776d6757412628d82efc3829405d063ce at 2024-06-22T14:28:56.293Z :recycle:
VladLazar commented 1 week ago

test_graceful_cluster_restart is failing because this pr is not based on: https://github.com/neondatabase/neon/pull/8061