pageserver: remove attach/detach apis - Githubissues

neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.

https://neon.tech

Apache License 2.0

13.18k stars 367 forks source link

pageserver: remove attach/detach apis #8134

Closed jcsp closed 3 days ago

jcsp commented 5 days ago

Problem

These APIs have been deprecated for some time, but were still used from test code.

Closes: https://github.com/neondatabase/neon/issues/4282

Summary of changes

It is still convenient to do a "tenant_attach" from a test without having to write out a location_conf body, so those test methods have been retained with implementations that call through to their location_conf equivalent.

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

github-actions[bot] commented 5 days ago

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)

Code coverage* (full report)

functions: 32.7% (6867 of 21000 functions)
lines: 50.2% (53632 of 106900 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
810bed0a4368acfbe56abc850840d450e67a99bd at 2024-06-25T14:47:33.511Z :recycle:}