pageserver: remove tenant create API - Githubissues

neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.

https://neon.tech

Apache License 2.0

14.48k stars 419 forks source link

pageserver: remove tenant create API #8135

Closed jcsp closed 3 months ago

jcsp commented 3 months ago

Problem

For some time, we have created tenants with calls to location_conf. The legacy "POST /v1/tenant" path was only used in some tests.

Summary of changes

Remove the API
Relocate TenantCreateRequest to the controller API file (this used to be used in both pageserver and controller APIs)
Rewrite tenant_create test helper to use location_config API, as control plane and storage controller do
Update docker-compose test script to create tenants with location_config API (this small commit is also present in https://github.com/neondatabase/neon/pull/7947)

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

github-actions[bot] commented 3 months ago

2934 tests run: 2817 passed, 0 failed, 117 skipped (full report)

Code coverage* (full report)

functions: 32.7% (6894 of 21102 functions)
lines: 50.0% (53912 of 107846 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
40847ed574e0fcb4c245504ae69f84bc64a0e184 at 2024-06-26T19:33:06.400Z :recycle:}