Closed conradludgate closed 3 months ago
test_websockets
: release, debug
test_websockets
: release, debug
test_websockets_pipelined
: release, debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_http_pool_begin_1[release-pg14] or test_http_pool_begin_1[debug-pg14] or test_proxy_server_params[release-pg14] or test_proxy_server_params[debug-pg14] or test_proxy_options[release-pg14-endpoint] or test_proxy_options[debug-pg14-endpoint] or test_proxy_options[release-pg14-project] or test_proxy_options[debug-pg14-project] or test_auth_errors[release-pg14] or test_auth_errors[debug-pg14] or test_close_on_connections_exit[release-pg14] or test_close_on_connections_exit[debug-pg14] or test_sql_over_http_output_options[release-pg14] or test_sql_over_http_output_options[debug-pg14] or test_sql_over_http[release-pg14] or test_sql_over_http[debug-pg14] or test_sql_over_http_serverless_driver[release-pg14] or test_sql_over_http_serverless_driver[debug-pg14] or test_sql_over_http_pool[release-pg14] or test_sql_over_http_pool[debug-pg14] or test_sql_over_http_batch[release-pg14] or test_sql_over_http_batch[debug-pg14] or test_sql_over_http_batch_output_options[release-pg14] or test_sql_over_http_batch_output_options[debug-pg14] or test_sql_over_http_urlencoding[release-pg14] or test_sql_over_http_urlencoding[debug-pg14] or test_sql_over_http_pool_dos[release-pg14] or test_sql_over_http_pool_dos[debug-pg14] or test_http_pool_begin[release-pg14] or test_http_pool_begin[debug-pg14] or test_sql_over_http_pool_idle[release-pg14] or test_sql_over_http_pool_idle[debug-pg14] or test_sql_over_http2[release-pg14] or test_sql_over_http2[debug-pg14] or test_sql_over_http_connection_cancel[release-pg14] or test_sql_over_http_connection_cancel[debug-pg14] or test_forward_params_to_client[release-pg14] or test_forward_params_to_client[debug-pg14] or test_password_hack[release-pg14] or test_password_hack[debug-pg14] or test_sql_over_http_pool_custom_types[release-pg14] or test_sql_over_http_pool_custom_types[debug-pg14] or test_proxy_select_1[release-pg14] or test_proxy_select_1[debug-pg14] or test_proxy_psql_allowed_ips[release-pg14] or test_proxy_psql_allowed_ips[debug-pg14] or test_proxy_http_allowed_ips[release-pg14] or test_proxy_http_allowed_ips[debug-pg14] or test_websockets[release-pg14] or test_websockets[debug-pg14] or test_websockets_pipelined[release-pg14] or test_websockets_pipelined[debug-pg14] or test_password_hack[release-pg15] or test_password_hack[debug-pg15] or test_proxy_options[release-pg15-endpoint] or test_proxy_options[debug-pg15-endpoint] or test_forward_params_to_client[release-pg15] or test_forward_params_to_client[debug-pg15] or test_http_pool_begin_1[release-pg15] or test_http_pool_begin_1[debug-pg15] or test_sql_over_http_serverless_driver[release-pg15] or test_sql_over_http_serverless_driver[debug-pg15] or test_sql_over_http[release-pg15] or test_sql_over_http[debug-pg15] or test_proxy_options[release-pg15-project] or test_proxy_options[debug-pg15-project] or test_sql_over_http_output_options[release-pg15] or test_sql_over_http_output_options[debug-pg15] or test_sql_over_http_batch[release-pg15] or test_sql_over_http_batch[debug-pg15] or test_sql_over_http_batch_output_options[release-pg15] or test_sql_over_http_batch_output_options[debug-pg15] or test_sql_over_http_pool[release-pg15] or test_sql_over_http_pool[debug-pg15] or test_sql_over_http_urlencoding[release-pg15] or test_sql_over_http_urlencoding[debug-pg15] or test_http_pool_begin[release-pg15] or test_http_pool_begin[debug-pg15] or test_sql_over_http_pool_idle[release-pg15] or test_sql_over_http_pool_idle[debug-pg15] or test_auth_errors[release-pg15] or test_auth_errors[debug-pg15] or test_close_on_connections_exit[release-pg15] or test_close_on_connections_exit[debug-pg15] or test_sql_over_http_pool_dos[release-pg15] or test_sql_over_http_pool_dos[debug-pg15] or test_sql_over_http_pool_custom_types[release-pg15] or test_sql_over_http_pool_custom_types[debug-pg15] or test_sql_over_http_connection_cancel[release-pg15] or test_sql_over_http_connection_cancel[debug-pg15] or test_sql_over_http2[release-pg15] or test_sql_over_http2[debug-pg15] or test_proxy_select_1[release-pg15] or test_proxy_select_1[debug-pg15] or test_proxy_server_params[release-pg15] or test_proxy_server_params[debug-pg15] or test_proxy_http_allowed_ips[release-pg15] or test_proxy_http_allowed_ips[debug-pg15] or test_proxy_psql_allowed_ips[release-pg15] or test_proxy_psql_allowed_ips[debug-pg15] or test_websockets_pipelined[release-pg15] or test_websockets_pipelined[debug-pg15] or test_websockets[release-pg15] or test_websockets[debug-pg15] or test_http_pool_begin_1[release-pg16] or test_http_pool_begin_1[debug-pg16] or test_password_hack[release-pg16] or test_password_hack[debug-pg16] or test_auth_errors[release-pg16] or test_auth_errors[debug-pg16] or test_proxy_select_1[release-pg16] or test_proxy_select_1[debug-pg16] or test_proxy_server_params[release-pg16] or test_proxy_server_params[debug-pg16] or test_proxy_options[release-pg16-project] or test_proxy_options[debug-pg16-project] or test_forward_params_to_client[release-pg16] or test_forward_params_to_client[debug-pg16] or test_close_on_connections_exit[release-pg16] or test_close_on_connections_exit[debug-pg16] or test_sql_over_http_serverless_driver[release-pg16] or test_sql_over_http_serverless_driver[debug-pg16] or test_sql_over_http_output_options[release-pg16] or test_sql_over_http_output_options[debug-pg16] or test_sql_over_http[release-pg16] or test_sql_over_http[debug-pg16] or test_sql_over_http_batch[release-pg16] or test_sql_over_http_batch[debug-pg16] or test_http_pool_begin[release-pg16] or test_http_pool_begin[debug-pg16] or test_sql_over_http_batch_output_options[release-pg16] or test_sql_over_http_batch_output_options[debug-pg16] or test_sql_over_http_pool[release-pg16] or test_sql_over_http_pool[debug-pg16] or test_sql_over_http_pool_idle[release-pg16] or test_sql_over_http_pool_idle[debug-pg16] or test_sql_over_http2[release-pg16] or test_sql_over_http2[debug-pg16] or test_sql_over_http_urlencoding[release-pg16] or test_sql_over_http_urlencoding[debug-pg16] or test_sql_over_http_pool_custom_types[release-pg16] or test_sql_over_http_pool_custom_types[debug-pg16] or test_sql_over_http_pool_dos[release-pg16] or test_sql_over_http_pool_dos[debug-pg16] or test_sql_over_http_connection_cancel[release-pg16] or test_sql_over_http_connection_cancel[debug-pg16] or test_proxy_options[release-pg16-endpoint] or test_proxy_options[debug-pg16-endpoint] or test_proxy_psql_allowed_ips[release-pg16] or test_proxy_psql_allowed_ips[debug-pg16] or test_proxy_http_allowed_ips[release-pg16] or test_proxy_http_allowed_ips[debug-pg16] or test_websockets_pipelined[release-pg16] or test_websockets_pipelined[debug-pg16] or test_websockets[release-pg16] or test_websockets[debug-pg16]"
no measurable difference in staging.
Problem
postgres authentication to compute is slow. might save a few ms by skipping 1 round trip. We know we will use SCRAM-SHA-256, so there's no point of waiting for postgres to tell us.
Summary of changes
Checklist before requesting a review
Checklist before merging