When layer visibility was added, an info log was included for the situation where actual access to a layer disagrees with the visibility calculation. This situation is safe, but I was interested in seeing when it happens.
The log is pretty high volume, so this PR refines it to fire less often.
Summary of changes
For cases where accessing non-visible layers is normal, don't log at all.
Extend a unit test to increase confidence that the updates to visibility on access are working as expected
During compaction, only call the visibility calculation routine if some image layers were created: previously, frequent calls resulted in the visibility of layers getting reset every time we passed through create_image_layers.
Checklist before requesting a review
[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.
Checklist before merging
[ ] Do not forget to reformat commit message to not include the above checklist
Problem
When layer visibility was added, an info log was included for the situation where actual access to a layer disagrees with the visibility calculation. This situation is safe, but I was interested in seeing when it happens.
The log is pretty high volume, so this PR refines it to fire less often.
Summary of changes
Checklist before requesting a review
Checklist before merging