neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.
https://neon.tech
Apache License 2.0
15.15k stars 442 forks source link

pageserver: suppress noisy "layer became visible" logs #9064

Closed jcsp closed 1 month ago

jcsp commented 1 month ago

Problem

When layer visibility was added, an info log was included for the situation where actual access to a layer disagrees with the visibility calculation. This situation is safe, but I was interested in seeing when it happens.

The log is pretty high volume, so this PR refines it to fire less often.

Summary of changes

Checklist before requesting a review

Checklist before merging

github-actions[bot] commented 1 month ago

4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)


Flaky tests (6) #### Postgres 17 - `test_pageserver_compaction_smoke`: [release-arm64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/f08716c3eb261a35d11a79ed9535ded6/d9d603c1bcff4813/retries) - `test_ondemand_wal_download_in_replication_slot_funcs`: [release-x86-64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/180444c850d4a41d41eb0a410dc16d84/94be3081e2ba8119/retries) - `test_scrubber_physical_gc[4]`: [debug-x86-64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/616e84f65c91fe4bc748db7447d35268/d697233fb0326755/retries), [release-arm64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/616e84f65c91fe4bc748db7447d35268/b72523b93b24ac87/retries) #### Postgres 16 - `test_subscriber_restart`: [release-x86-64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/8be0c222d5601535470e7e5978bbfb03/e9487b6662116cf2/retries) - `test_timeline_delete_works_for_remote_smoke`: [release-arm64](https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9064/10945147732/index.html#suites/f588e0a787c49e67b29490359c589fae/23c7f3b05c9d7129/retries)

Code coverage* (full report)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
53437f7e869ac68c86c7d3e4c20964c0156f158c at 2024-09-20T16:17:15.785Z :recycle: