neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.
https://neon.tech
Apache License 2.0
14.48k stars 420 forks source link

pageserver: add counters for started smgr/getpage requests #9069

Closed problame closed 1 week ago

problame commented 1 week ago

After this PR

curl localhost:9898/metrics | grep smgr_ | grep start
pageserver_smgr_query_started_count{shard_id="0000",smgr_query_type="get_page_at_lsn",tenant_id="...",timeline_id="..."} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_db_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_page_at_lsn"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_exists"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_slru_segment"} 0

We instantiate the per-tenant counter only for get_page_at_lsn.

github-actions[bot] commented 1 week ago

5046 tests run: 4881 passed, 1 failed, 164 skipped (full report)


Failures on Postgres 17

Postgres 17

Code coverage* (full report)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
90b23405d17e36048d3bb64e314067f397803f1b at 2024-09-20T13:18:13.749Z :recycle: