pageserver: aux keys go to all shards

neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.

https://neon.tech

Apache License 2.0

15.26k stars 445 forks source link

pageserver: aux keys go to all shards #9641

Open VladLazar opened 2 weeks ago

VladLazar commented 2 weeks ago

While reading some unrelated code, I noticed that we write aux keys to all shards. Apparently, they should only be on shard 0. I checked out the code prior to my sharded ingest work and believe that has always been the case.

We should:

make sure that's the current state of affairs (I'm pretty sure - but let's check)
only write aux keys to shard 0

jcsp commented 5 days ago

I'm picking this up in https://github.com/neondatabase/neon/pull/9786 where we're also changing SLRUs to only go on shard 0