scan_log_for_errors: check that regex is correct - Githubissues

neondatabase / neon

Neon: Serverless Postgres. We separated storage and compute to offer autoscaling, code-like database branching, and scale to zero.

https://neon.tech

Apache License 2.0

15.22k stars 444 forks source link

scan_log_for_errors: check that regex is correct #9815

Closed bayandin closed 2 days ago

bayandin commented 2 days ago

Problem

I've noticed that we have 2 flaky tests which failed with error:

re.error: missing ), unterminated subpattern at position 21

test_timeline_archival_chaos — has been fixed in https://github.com/neondatabase/neon/pull/9777/commits/db743a8cd06c39fb520ce3d79493a4e4e230c106
test_sharded_tad_interleaved_after_partial_success — I didn't manage to find the incorrect regex
- an example
- another example

Summary of changes

Wrap re.match in try..except block and print incorrect regex

github-actions[bot] commented 2 days ago

5517 tests run: 5291 passed, 0 failed, 226 skipped (full report)

Code coverage* (full report)

functions: 31.4% (7937 of 25247 functions)
lines: 49.6% (62999 of 127010 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
2e3a7638747e564a4f6d1af1cc0c3b3438fbb740 at 2024-11-20T01:40:19.648Z :recycle:}