search

neondatabase / postgres

PostgreSQL in Neon
https://neon.tech/docs/reference/compatibility
27 stars 12 forks source link

Fix usage of pg_waldump --ignore option. #418

Closed lubennikovaav closed 6 months ago

lubennikovaav commented 6 months ago

Previously, the --ignore option was only used when reading from a single file.

With this PR pg_waldump -i is enough to open any neon WAL segments

kelvich commented 6 months ago

Let's add test with usage of pg_waldump on a first neon wal segment. IMO the easiest way would be to do that in neon repo python tests -- init empty database and check that waldump works on safekeeper wal. For all pg version.

Then it would be really easy to review this: some confirmation that this thing works and waldump is not on the critical path, so quick code read is enough