search

neontribe / www

Neontribe's own website
https://www.neontribe.co.uk
MIT License
2 stars 5 forks source link

Accessibility and Function / Purpose we want from scrolling logo banner #267

Open Nikomus opened 5 years ago

Nikomus commented 5 years ago

Describe the bug The ex-HexagonGrid component traps screenreaders in a succession of missing image description alerts. This component should also be pausable, without the user have to maintain a pointer position to do so.

To Reproduce Steps to reproduce the behavior:

  1. Go to '/what-we-are-doing/'
  2. Use a screenreader to read the page

Expected behavior The component should have an accessible description. The animation should be clearly stoppable.

Desktop (please complete the following information):

rosejbon commented 4 years ago

Needs to be split into 2 cards:

  1. Hotfix accessibility sweep
  2. UX review
falconx commented 4 years ago

@Nikomus

The HexagonGrid component traps screenreaders in a succession of missing image description alerts.

I wasn't able to reproduce this.

This component should also be pausable, without the user have to maintain a pointer position to do so.

Where does this requirement come from? Is it mentioned in WCAG?

Nikomus commented 4 years ago

@falconx After updating NVDA I now can't reproduce the successive missing image descriptions - the section is just skipped. I think this component is meant to address user story: "I want to see that Neontribe have worked with funding bodies before so that I can strengthen my funding application" so perhaps we should add some clarity to that alongside any accessibility improvements?

I think WCAG criterion 2.2.2 applies here: https://www.w3.org/WAI/WCAG21/Understanding/pause-stop-hide.html

falconx commented 4 years ago

perhaps we should add some clarity to that

Do you mean, making it clearer that the images refer to funding bodies?

WCAG criterion 2.2.2

:ok_hand: I remember seeing this before now. couldn't remember if it was AAA or that was a threshold whether it was only necessary at a certain animation speed. But you're quite right, we should really have a play/pause button.

Nikomus commented 4 years ago

Yeah, I think if you're someone interested in knowing which funding bodies we've worked with you're more likely to be aware of what the logos mean, but in future we could have a little more information, and be screen-readable.

We may also want to look at this for the scrolling, but probs wait until we know any other changes https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

falconx commented 4 years ago

We may also want to look at this for the scrolling, but probs wait until we know any other changes https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

I agree. I was thinking about this too. It's actually part of the CSS reset I now use on all my projects:

falconx commented 4 years ago

we should really have a play/pause button.

I was thinking that a nice way to implement this could be like how we have "skip to content" links, where the link only appears on tab focus.

katjam commented 4 years ago

Discussed at #352:

Agreed that there is a user story about it being obvious that we work on projects from a range of funders rather by the organisation we build them for.

Agreed also that there is a user story about showcasing our UX/UI and Visual design skills.

Uncertain that even if we were able to solve the accessibility issue whether the current solution meets either of the stories as well as we might like.

Suggestion: If a) the accessibility fix is complicated and b) displaying logos might need revisiting to better meet the user story then we could apply fixes in two phases:

1) Remove current feature block from page. Add a line of copy mentioning the funder to the 3 social good projects on the page. 2) explore a design for displaying funder logos that would allow us to add new funders as we work on projects for them (allowing us to showcase a much wider range than currently, and include gov department). This could either be implemented before we develop a project filter or ahead of that later feature.

We want a wider discussion to decide the way forward - whilst making sure that the resolution of the accessibility issue stays top priority.

Nikomus commented 1 year ago

This isn't in the site anymore.