search

neonwatty / machine_learning_refined

Notes, examples, and Python demos for the 2nd edition of the textbook "Machine Learning Refined" (published by Cambridge University Press).
Other
1.7k stars 610 forks source link

Missing initialization in Exercise 6.5 MATLAB wrapper #3

Closed Andrew-S-Rosen closed 7 years ago

Andrew-S-Rosen commented 7 years ago

In the MATLAB wrapper for Exercise 6.5, the parameters b, w, c, and V used in the tanh_softmax function are not initialized. The code will not successfully run then even if grad_b, grad_w, grad_c, and grad_V are written correctly.

RezaBorhani commented 7 years ago

Thanks Andrew for pointing this out! It's been fixed now.