search

neooffice / NeoOffice

Other
34 stars 5 forks source link

[Feature] adopt newer icon themes #4

Open foss- opened 2 years ago

foss- commented 2 years ago

LibreOffice has a few more modern icon themes like

Are there plans to add those in NeoOffice?

plubius commented 2 years ago

While working on issue #5, I tried using the "Sifr dark" icons from LibreOffice 7.3.4.2 in NeoOffice 2022. Copying an icon set can be done by executing the following command in the Terminal and then restarting NeoOffice:

sudo cp /Applications/LibreOffice.app/Contents/Resources/config/images_sifr_dark.zip /Applications/NeoOffice.app/Contents/Resources/config/

Then, after selecting the copied icon set in the Preferences dialog and restarting NeoOffice a second time, most of the icons displayed the LibreOffice icon set but for many icons, only text is displayed instead of an icon.

I did a quick comparison of the links.txt file and the icon file name changes between LibreOffice 4.4 (the code that NeoOffice is based on) and LibreOffice 7.3. It appears that more than 1000 keys in the links.txt were removed and roughly the same number of icon file names were removed as well. Presumably these were replaced by new keys and file names but I could not see any obvious pattern.

fitojb commented 2 years ago

Time to bump the base LibreOffice version? :)

plubius commented 1 year ago

We have just started working on upgrading the NeoOffice code to use the LibreOffice 7.4.x code and we should be able to get LibreOffice's more recent Skia icons instead of my filtered older Skia icons.

It will take at least a few months to get the upgrade to a beta release but I have set the milestone to NeoOffice 2023 so that we don't forget to test and fix any bugs in Dark Mode or Light Mode when using LibreOffice 7.4.x's two Skia icon sets after we finish upgrading our code.