Sifr icons visibility suffering from low contrast in dark mode

[foss-]

macOS 12.3.1 NeoOffice 2022 Professional Edition

Sifr icons not visible in dark mode:

[plubius]

The fix for this bug is in the NeoOffice 2022 Test 3 test patches

[foss-]

Downloaded Test 3 from https://github.com/neooffice/NeoOffice/releases (wasn't aware test builds were available inside of the current release - would it make sense to publish those as separate pre-releases on GitHub instead?). Could not install the test build. Enough disk space available:

[plubius]

From your screen snapshot, you are trying to install the test patch for the Mac App Store but your first post says you are running Professional Edition so try installing the test patch for the NeoOffice 2022 Professional Edition.

For completeness, below are links to the test patches for both the Mac App Store and Professional Edition versions:

• NeoOffice 2022 Mac App Store
• NeoOffice 2022 Professional Edition

[foss-]

You are correct. Although I find the naming a bit confusing at https://github.com/neooffice/NeoOffice/releases/tag/NeoOffice-2022

How would a user distinguish MAS vs Standalong in that naming scheme?

Installed the Pro edition you linked but sifr is still showing like this:

Hm about says Patch 0. Sounds wrong. Re-downloaded NeoOffice-2022_Professional_Edition-Patch-0-Test-3-Universal.dmg but the pkg already shows as Patch 0.

Also about is hard to read in dark mode. Do you want a separate issue for that?

[plubius]

I found LibreOffice code that is setting About dialog text to light gray. For some reason, the code overrode the application default colors by hardcoding the light gray text color so I removed that code.

Also, I've been using the Sifr icon theme for the last week and I found that with my last fix, it is still difficult to see when the Save icon changed from disabled to enabled. Since the Sifr icons are unfortunately all hardcoded, medium gray bitmaps, I experimented with setting the window background color to various system colors and I found enabled Sifr icons most readable in Dark Mode when the window background is nearly black.

My latest fix is definitely a hack. Disabled icons are still difficult to read and the fix definitely gives NeoOffice a "high contrast" look when using the Sifr in Dark Mode, but it might work until someone comes up with a better fix or figures out how to mass convert the thousands of Sifr icons to a much lighter shade of gray (maybe someone knows how do that in ImgeMagick?).

Anyway, below are links to the test patches with the About dialog fix and the hacky window background fix:

• NeoOffice 2022 Mac App Store
• NeoOffice 2022 Professional Edition

[foss-]

Thanks for not giving up on this (I thought you did when you unassigned from the issue).

Ugh, medium grey hardcoded? Sounds like a weird design choice. That makes background color selection very narrow as anything not close to black will result in too little contrast.

In LibreOffice main there are light and dark icon themes for Sifr as well as SVG variants of dark and light icon theme. Would that maybe be useful to utilize Sifr in a more flexible manner?

This is after the most recent patch.

The darker color for the calc rows and columns looks a bit rough. Maybe decouple that from the icon background color at the top?

About:

Sifr Icons:

[plubius]

I spent some time experimenting with ImageMagick in an attempt to whiten the Sifr icons so that they would be visible without having to make the window background color nearly black. Unfortunately, whitening worked for many icons, but for many others (like in Writer 's Table toolbar) whitening resulted in a nearly white square.

However, darkening the Sifr icons, though not as readable as whitened icons, seems to increase readability without having to make the window background color nearly black and without losing the fine lines and shading that many icons have.

Below are links to the test patches with nearly black Sifr icons:

• NeoOffice 2022 Mac App Store
• NeoOffice 2022 Professional Edition

[foss-]

For reference this is after latest patches:

[plubius]

The darkened Sifr icons change is included in NeoOffice 2022.1:

• NeoOffice 2022.1 Professional Edition
• NeoOffice 2022.1 in the Mac App Store

[foss-]

Do you want to close this bug here then? Implementing a proper dark mode solution will probably require bumping base LibreOffice version as mentioned in https://github.com/neooffice/NeoOffice/issues/4#issuecomment-1160423495.

In any case, both light and dark mode sifr have improved with your changes.

[plubius]

OK. Closing this bug. But I'll keep Issue #4 open in case I find some way to map the old image names to the newer ones in the links.txt file within each of the icons' .zip files.