Would you please consider my codes

neophenix / Redis-hiredis

Perl wrapper around hiredis client

BSD 3-Clause "New" or "Revised" License

11 stars 8 forks source link

Would you please consider my codes #2

Closed zigorou closed 12 years ago

zigorou commented 12 years ago

Hi.

My name is Toru Yamaguchi. I'm perl mongers in Japan. I patched some features to Redis::hiredis.

Upgrade libhiredis to 0.10.1 and rename some files. Because your original code might be renamed files from libhiredis headers and sources.
Support connect_unix() method. It is available to connect by unix domain socket.
Support connect_fd() method. It is available to connect by fd. The reason why I wrote this feature, I want to use connection pooling by sendmsg(2) and recvmsg(2).
Modified some memory allocation codes, But I'm not good to write XS codes. Please check it.

Regards.

neophenix commented 12 years ago

I've been looking at the changes to merge this, most seem reasonable, however the tests are no longer passing if no REDISHOST is defined so that needs fixed, not sure when I can get to that.

Additionally, I'm not going to change malloc and free, this sentence alone should tell people to avoid the perl macros: "However, on some platforms, it may cause spurious malloc or free errors." So I'll need to pick out just the changes I want.

Edit: Also there are a lot of warning now when compiling (at least on OS X) that I would like to clean up if at all possible.

neophenix commented 12 years ago

Hello Toru,

Its been a long time, but I finally got a good chunk of your pull request committed, and attributed you in the Changes. I haven't solved the seg faulting issue, and I didn't pull in the file descriptor connecting yet, but the unix socket connection is there, tested and working.

When I get to the FD stuff I'll finally close this out.

zigorou commented 12 years ago

Hello neophenix.

Sorry, my response is too late. Thank you merging my code. I thought communicating with fd is very convenient to server's resource usage. But almost persons might not want to this feature. So you would not merge it fixing seg-fault is hard. Regards.

zigorou commented 12 years ago

Additional, When I have enough time, I'll look the codes and tests arround fd.