search

neopixeldev / hypixel-api-java

Asynchronous Java wrapper for the Hypixel API
MIT License
6 stars 2 forks source link

Change HashMap to EnumMap in caching #60

Closed Netwyn closed 2 years ago

Netwyn commented 2 years ago

Changed HashMap to an EnumMap in class BasicCachingStrategy

Unsure of its real benefits, but it is recommended to be used in scenarios where the key value of the HashMap is meant to be an enum.

Netwyn commented 2 years ago

I don't see any downsides to doing this, plus it's recommended practice.

JxBP commented 2 years ago

Wasn't this supposed to be an abstract Query class instead of an Endpoint enum later on?