Exception handling - Githubissues

neopixeldev / hypixel-api-java

Asynchronous Java wrapper for the Hypixel API

MIT License

6 stars 2 forks source link

Closed unpluggedsam closed 2 years ago

unpluggedsam commented 2 years ago

Handle exceptions thrown from the API. ⚫ Accept codes 200 - 300 returned from API. ⚫ Handle codes 400, 403, 422 and 429 with custom exceptions. ⚫ Handle null player and guild objects with custom exceptions. ⚫ Handle unknown exceptions with UnknownAPIException.
Refactor PineappleException to NovopixelException.
Refactor toString() of NovopixelException (may want to change in the future.)

Nopock commented 2 years ago

Looks good, except we haven't decided on a name yet. Novopixel isn't sticking as far as I know.

I'm in agreement 😄

Netwyn commented 2 years ago

@unpluggedsam update: I believe the name we're using is Neopixel, as far as the votes go.

unpluggedsam commented 2 years ago

For future reference, the refactoring of the name should've been put in another PR.