search

neopostmodern / wohnungsbot

Der Wohnungsbot — die Anwendung zum 2. Akt ("Das Versprechen des Bots") des Automatisierungsdramas in drei Akten "Von einem der auszog eine Wohnung in Berlin zu finden" von Clemens Schöll
https://wohnungsbot.de
GNU Affero General Public License v3.0
151 stars 27 forks source link

Fix #83 #106

Closed drblaui closed 2 years ago

drblaui commented 2 years ago

This should actually sort flats by new.

As mentioned in #83, I just simply add sorting=2 into the URL after load by direct JS execution. This is (for me at least) the easiest implementation I could think of

I tested it locally (however I do suggest testing it a lot more) and the bot was still able to do everything as normal. However, it seems to have some kind of slow start when searching for flats, but I'm not sure if that's my hardware and I always had that problem or not, so it's not that much noticeable

drblaui commented 2 years ago

After leaving it to run for a while, this actually tends to break the bot, as it can't handle the page refreshing, neverming

neopostmodern commented 2 years ago

Let's see if there's a fix for the issue you describe before discarding this completely :) I think it could be an easier solution than clicking through the sorting menu...

drblaui commented 2 years ago

The fix would be stopping that the bot doesn't do anything until the sorting=2 parameter is present in the URL. However, I don't seem to have a deep enough understanding of the bot actions to be able to stop him from evaluating flats, before the page has refreshed

neopostmodern commented 2 years ago

Here's what I'll do – merge this as is, add a checkbox for people to enable this experimental (in another commit), but make it default off so that the zero-config experience still works reliably.