neos-modding-group / NeosModLoader

A mod loader for Neos VR
GNU Lesser General Public License v3.0
61 stars 22 forks source link

Propper unified formatting #59

Closed ljoonal closed 2 years ago

ljoonal commented 2 years ago

Fixes CI hopefully.

I recommend reviewing with whitespace hidden. image

ljoonal commented 2 years ago

I'm sure the CI will just magically fix itself if we merge this , right @zkxs ? x'D I think that's how to read the one passing & one failing CI thing at least...

EIA485 commented 2 years ago

Time to test in prod I guess ¯_(ツ)_/¯

zkxs commented 2 years ago

Hello merge conflicts my old friend~

EIA485 commented 2 years ago

this seems to have messed up all of the indention. everything is only intended 2 spaces instead of 4

zkxs commented 2 years ago

Surely that was intentional? I doubt LJ overlooked a +2000 -2000 line diff.

EIA485 commented 2 years ago

our CONTRIBUTING.md states cs files should have a 4 space indentation

zkxs commented 2 years ago

our CONTRIBUTING.md states cs files should have a 4 space indentation

Well, seems like the move is to update CONTRIBUTING.md, then. #62 does that.

ljoonal commented 2 years ago

Apologies, I should've done more checking that the update matches the current styles instead of just quickly trying to fix the CI.