neos-modding-group / NeosModLoader

A mod loader for Neos VR
GNU Lesser General Public License v3.0
61 stars 22 forks source link

Implement #75 - Command Line Argument parsing utility and config #96

Open Banane9 opened 1 year ago

Banane9 commented 1 year ago

Implements an expanded upon Version of the feature requested by @art0007i in #75.

Also changed config loading to use reflection to make it more compact, more permissive and easy to add new values.
Added some inverted properties to allow setting them with flag arguments.

art0007i commented 1 year ago

maybe instead of putting all the neos default argument parsing code inside of the loader itself, it would be better to create a library mod that can be used by other mods? we have Libraries category in the manifest that seems like it would be perfect for this

Banane9 commented 1 year ago

I'm generally in favor of making things more generic like this would do with parsing the config,

hey, doing the config parsing "manually" is @zkxs's doing. I've used an ini Parser in the SpotifyStatus server, but that's another library and also only parses it into a string dictionary style afaik

maybe instead of putting all the neos default argument parsing code inside of the loader itself, it would be better to create a library mod that can be used by other mods? we have Libraries category in the manifest that seems like it would be perfect for this

but if it's a library I can't use it for NML's config 😝