Site export contains disabled nodes

neos / Neos.Demo

The Neos demo site package

GNU General Public License v3.0

18 stars 36 forks source link

Site export contains disabled nodes #118

Closed bwaidelich closed 2 years ago

bwaidelich commented 2 years ago

Since #57 the Neos.Demo Sites.xml export contains 5 disabled (aka "hidden") document nodes:

https://github.com/neos/Neos.Demo/blob/38ef33a5131ad6d834f821766ea0fac47eddb121/Resources/Private/Content/Sites.xml#L2992-L3044

I doubt this was done on purpose, but I might be missing something. @mficzel maybe you can recall?

mficzel commented 2 years ago

That was surely not on purpose. Probably just me beeing clumsy.

mficzel commented 2 years ago

@bwaidelich those hidden nodes are the "Neos.Demo:Document.NotFoundPage" in non default dimension. As we are currently rendering the 404 in the default dimension i would consider this correct as they are autocreated as children of root.

bwaidelich commented 2 years ago

Ah I see, thanks for the explanation!