search

neos / Neos.Demo

The Neos demo site package
GNU General Public License v3.0
18 stars 36 forks source link

TASK: Remove usage of Neos.Neos:PrimaryContent to render the main content collection #170

Closed ahaeslich closed 1 year ago

ahaeslich commented 1 year ago

Triggered by testing the pull request https://github.com/neos/neos-development-collection/pull/4281#issuecomment-1549938033 I would suggest to switch the usage of Neos.Neos:PrimaryContent to Neos.Neos:ContentCollection as I can see no advantage of using it in the demo.

Any objections? If not: Do we want to target the changes for v8.3 or introduce them in the v9 branch?

Current usages:

ahaeslich commented 1 year ago

@jonnitto / @Sebobo / @mficzel any thoughts?

mficzel commented 1 year ago

Never really figured out what primary content is anyways. So fine with me. I suggest to target 9.0

Sebobo commented 1 year ago

With the initial page concept it had some uses for extensibility. Like I used it for my blog package which didn't have its own page type back then. But I think nowadays there is no use for it anymore.

I'm fine with replacing it even in 8.3 now. We will have to use 8.3 for quite a while now as example.