search

neos / Neos.Demo

The Neos demo site package
GNU General Public License v3.0
18 stars 36 forks source link

FEATURE: Implement component for displaying Favicons in frontend #176

Open crydotsnake opened 1 year ago

mhsdesign commented 1 year ago

Thanks for your work ^^ Is it normal that this seems so complex / verbose?

I mean this is supposed to be a exemplary demo - im not sure if this wouldnt scare people away :P

... But if this is the way. I would not oppose.

image
crydotsnake commented 1 year ago

Well. You could also use a fluid file with the HTML for the favicons. And a fusion file that inherits from Neos.Fusion:Template and just has the package and the Fluid file as the templatePath as propertys.

But the idea as I have solved it here came to me as the first thought.

But both solutions are not complex at all IMO 🤔

crydotsnake commented 1 year ago

Today you don't need so many icons anymore, see https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs or other articles.

First i thought about using a favicon generator. For example: https://realfavicongenerator.net/

But was not sure if this would be a good solution. Wdyt?

Sebobo commented 1 year ago

Why not just remove the tags you don't need and keep the rest and just do a few adjustments? Don't fully understand your question regarding the generator and how it would help?

Sebobo commented 1 month ago

Should target 8.4 though

crydotsnake commented 1 month ago

Should target 8.4 though

Done.