neos / Neos.DocsNeosIo

The docs.neos.io website
9 stars 11 forks source link

TASK: Update to Neos 8.2 #100

Closed markusguenther closed 1 year ago

markusguenther commented 1 year ago

Currently, this branch is used on staging.

To-dos:

markusguenther commented 1 year ago

For the notifier, we just need to wait for @rolandschuetz to merge and release https://github.com/code-q-web-factory/neos-publishnotifier/pull/7

kdambekalns commented 1 year ago

Uh, .warmupdone should be removed and put into .gitignore as to not possibly confuse (real) Beach…

markusguenther commented 1 year ago

Uh, .warmupdone should be removed and put into .gitignore as to not possibly confuse (real) Beach…

Ah ok good to have you. Just checked your upgrade from neos.io and saw the changes ;)

markusguenther commented 1 year ago

The HTML widget package is only used for this column. So we don't re-add this and just use content for that. Screenshot 2022-11-30 at 12 02 36

manuelmeister commented 1 year ago

I use it for the fusionpen examples in #95. But I think this could be solved another way.

markusguenther commented 1 year ago

I use it for the fusionpen examples in #95. But I think this could be solved another way.

Hmm, Ok... just read that https://github.com/code-q-web-factory/neos-htmlwidget/pull/4 and as Roland today announced that he will take a break, we need to fork it or integrate the feature. Or find another way to do that ;)

markusguenther commented 1 year ago

Ok here we have the same issue ... need to wait for Neos 8.2.2 https://github.com/neos/neos-development-collection/pull/3969

rolandschuetz commented 1 year ago

My packages which blocked the PR are updated.

manuelmeister commented 1 year ago

Why is the hypenation not working anymore on home with this PR? https://instance-6ee89105-ec8e-4024-97bb-5c2b9d49a15c.flownative.cloud/ Bildschirmfoto 2023-01-05 um 10 41 24

kdambekalns commented 1 year ago

Why is the hypenation not working anymore on home with this PR?

🤷‍♂️ https://github.com/neos/Neos.DocsNeosIo/pull/100/commits/d0988656ea41ec4ad80a328575ddc9b0f0143c1b seems innocent enough…

manuelmeister commented 1 year ago

The new version of the package removed the shy replace function we have used. Instead it uses phpSyllable for the hypenation: https://github.com/CarbonPackages/Carbon.Hyphen/pull/7

With this, || is not replaced anymore. Should we add such a "processor" back in, or how could we migrate the existing content?

kdambekalns commented 1 year ago

How often is || actually in the content?

manuelmeister commented 1 year ago

I just clicked around on the stage and found several: https://instance-6ee89105-ec8e-4024-97bb-5c2b9d49a15c.flownative.cloud/cms/features/testing

I think it would be best to replace || with the unicode shy character and install Shel.Neos.Hyphens as suggested by Roland.

mhsdesign commented 1 year ago

I think it would be best to replace || with the unicode shy character and install Shel.Neos.Hyphens as suggested by Roland.

this is the way ;) +1

Sebobo commented 1 year ago

So we can click around the stage again and check whether we are done here now.

markusguenther commented 1 year ago

Thank you very much to all of you 💙

markusguenther commented 1 year ago

I have added a small migration for the replacement of || to the soft hyphens. We just use it in the title property and somewhere in Code, but in the Code node types I did not replace it, of course.

From my side we can merge it. Tested it locally and on staging.

Replaced already the pipes on staging. Just need to run ./flow node:migrate --version=20230120000000 on live then.

Screenshot 2023-01-20 at 12 00 20